feat(expo-cli): add shortcut to open editor #1879

byCedric · 2020-04-14T18:22:20Z

This uses Sindre's env-editor and spawnAsync over some other options I've tried. The env editor basically tries to find the default editor, if that's not found it will fallback to vscode. If none of these 2 options work, it will log with an error and describes how to fix it.

I tested this on MacOS, Windows and Windows WSL 😄

Fun facts(tm)

open-editor didn't work that well for folders on both MacOS and Windows. On MacOS it thought it was a file and appended line and colon (/my/path:1:1) to this. On Windows there were some errors with --goto flag.
open didn't work on MacOS, apparently MacOS can't open vscode with open /my/path -a vscode (but does work with open /my/path -a "Visual Studio Code"). Also open didn't reject the first attempt, it resolved without errors.

codecov-io · 2020-04-14T18:36:42Z

Codecov Report

Merging #1879 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1879   +/-   ##
=======================================
  Coverage   59.95%   59.95%           
=======================================
  Files          84       84           
  Lines        2502     2502           
  Branches      687      694    +7     
=======================================
  Hits         1500     1500           
+ Misses        979      972    -7     
- Partials       23       30    +7

Impacted Files	Coverage Δ
packages/pwa/src/Manifest.ts	`37.25% <0.00%> (ø)`
packages/config/src/Config.ts	`58.16% <0.00%> (ø)`
packages/config/src/android/Manifest.ts	`69.79% <0.00%> (ø)`
...ackages/webpack-config/src/addons/withDevServer.ts	`33.33% <0.00%> (ø)`
...es/webpack-config/src/loaders/createBabelLoader.ts	`46.66% <0.00%> (ø)`
...webpack-config/src/plugins/FaviconWebpackPlugin.ts	`4.76% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9b581...5ece000. Read the comment docs.

byCedric · 2020-04-14T18:40:36Z

yarn.lock

@@ -4178,11 +4178,6 @@
  dependencies:
    "@types/node" "*"

-"@types/caseless@*":


Not sure what's going on here, looks like the yarn lockfile could be slightly outdated?

brentvatne · 2020-04-14T18:51:34Z

we have previously used the EXPO_EDITOR env var for this, i can't remember exactly where though, i think it might have been in XDE. i'm ok with not supporting this env var anymore though.

the old script for this is here:

expo-cli/packages/xdl/src/FileSystem.ts

Lines 47 to 55 in cc9e1d8

    
           export async function openFileInEditorAsync(path: string) { 
        
             if (process.platform === 'darwin') { 
        
               // This will use the ENV var $EXPO_EDITOR if set, or else will try various 
        
               // popular editors, looking for one that is open, or if none are, one that is installed 
        
               return await osascript.openInEditorAsync(path, process.env.EXPO_EDITOR); 
        
             } else { 
        
               throw new XDLError('PLATFORM_NOT_SUPPORTED', 'openFileInEditorAsync not supported'); 
        
             } 
        
           }

i wonder why we chose to use osascript 🤔 might be worth checking if we have any usage of this module any removing it if not

packages/expo-cli/src/commands/utils/EditorUtils.ts

byCedric added 3 commits April 14, 2020 18:27

feat(expo-cli): add shortcut to open editor

487bd49

refactor(expo-cli): use spawn async instead of open for editors

4acb8c9

refactor(expo-cli): hide open in editor from initial terminal ui

5ece000

byCedric requested a review from brentvatne April 14, 2020 18:22

byCedric commented Apr 14, 2020

View reviewed changes

brentvatne suggested changes Apr 14, 2020

View reviewed changes

packages/expo-cli/src/commands/utils/EditorUtils.ts Outdated Show resolved Hide resolved

Update packages/expo-cli/src/commands/utils/EditorUtils.ts

6ed04e6

brentvatne merged commit 2e130d6 into expo:master Apr 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(expo-cli): add shortcut to open editor #1879

feat(expo-cli): add shortcut to open editor #1879

byCedric commented Apr 14, 2020

codecov-io commented Apr 14, 2020

byCedric Apr 14, 2020

brentvatne commented Apr 14, 2020 •

edited

Loading

feat(expo-cli): add shortcut to open editor #1879

feat(expo-cli): add shortcut to open editor #1879

Conversation

byCedric commented Apr 14, 2020

codecov-io commented Apr 14, 2020

Codecov Report

byCedric Apr 14, 2020

Choose a reason for hiding this comment

brentvatne commented Apr 14, 2020 • edited Loading

brentvatne commented Apr 14, 2020 •

edited

Loading